algorithm/Java
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/Java.git synced 2025-07-06 17:29:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix AbsoluteMin bug for equal absolute values (#6145)

Browse Source 
* fix-absolute-max-bug

* clang-format for added junit

* fix-absolute-min-bug
This commit is contained in:
Muhammad Rizwan
2025-01-19 21:50:43 +05:00
committed by GitHub
parent 30d0c064a7
commit 0e0539ea6c
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/com/thealgorithms/maths/AbsoluteMin.java
View File

@ -19,7 +19,7 @@ public final class AbsoluteMin {
var absMinWrapper = new Object() { int value = numbers[0]; }; var absMinWrapper = new Object() { int value = numbers[0]; };
Arrays.stream(numbers).skip(1).filter(number -> Math.abs(number) < Math.abs(absMinWrapper.value)).forEach(number -> absMinWrapper.value = number); Arrays.stream(numbers).skip(1).filter(number -> Math.abs(number) <= Math.abs(absMinWrapper.value)).forEach(number -> absMinWrapper.value = Math.min(absMinWrapper.value, number));
return absMinWrapper.value; return absMinWrapper.value;
} }

8
src/test/java/com/thealgorithms/maths/AbsoluteMinTest.java
View File

@ -15,7 +15,13 @@ public class AbsoluteMinTest {
@Test @Test
void testGetMinValueWithNoArguments() { void testGetMinValueWithNoArguments() {
Exception exception = assertThrows(IllegalArgumentException.class, () -> AbsoluteMin.getMinValue()); Exception exception = assertThrows(IllegalArgumentException.class, AbsoluteMin::getMinValue);
assertEquals("Numbers array cannot be empty", exception.getMessage()); assertEquals("Numbers array cannot be empty", exception.getMessage());
} }
@Test
void testGetMinValueWithSameAbsoluteValues() {
assertEquals(-5, AbsoluteMin.getMinValue(-5, 5));
assertEquals(-5, AbsoluteMin.getMinValue(5, -5));
}
} }