From 0072ed9aa72eefc57361f96f27db17a86b790936 Mon Sep 17 00:00:00 2001
From: Piotr Idzik <65706193+vil02@users.noreply.github.com>
Date: Mon, 31 Mar 2025 19:20:58 +0200
Subject: [PATCH] style: do not suppress `lossy-conversions` (#6206)

---
 pom.xml                                           |  1 -
 .../java/com/thealgorithms/ciphers/Caesar.java    | 15 +++++++++------
 .../java/com/thealgorithms/maths/AliquotSum.java  |  2 +-
 .../com/thealgorithms/maths/PerfectNumber.java    |  2 +-
 4 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/pom.xml b/pom.xml
index b8ab98289..43c0a2b28 100644
--- a/pom.xml
+++ b/pom.xml
@@ -78,7 +78,6 @@
                         <arg>-Xlint:-auxiliaryclass</arg>
                         <arg>-Xlint:-rawtypes</arg>
                         <arg>-Xlint:-unchecked</arg>
-                        <arg>-Xlint:-lossy-conversions</arg>
                         <arg>-Werror</arg>
                     </compilerArgs>
                 </configuration>
diff --git a/src/main/java/com/thealgorithms/ciphers/Caesar.java b/src/main/java/com/thealgorithms/ciphers/Caesar.java
index 61c444cf6..23535bc2b 100644
--- a/src/main/java/com/thealgorithms/ciphers/Caesar.java
+++ b/src/main/java/com/thealgorithms/ciphers/Caesar.java
@@ -9,6 +9,9 @@ package com.thealgorithms.ciphers;
  * @author khalil2535
  */
 public class Caesar {
+    private static char normalizeShift(final int shift) {
+        return (char) (shift % 26);
+    }
 
     /**
      * Encrypt text by shifting every Latin char by add number shift for ASCII
@@ -19,7 +22,7 @@ public class Caesar {
     public String encode(String message, int shift) {
         StringBuilder encoded = new StringBuilder();
 
-        shift %= 26;
+        final char shiftChar = normalizeShift(shift);
 
         final int length = message.length();
         for (int i = 0; i < length; i++) {
@@ -29,10 +32,10 @@ public class Caesar {
             char current = message.charAt(i); // Java law : char + int = char
 
             if (isCapitalLatinLetter(current)) {
-                current += shift;
+                current += shiftChar;
                 encoded.append((char) (current > 'Z' ? current - 26 : current)); // 26 = number of latin letters
             } else if (isSmallLatinLetter(current)) {
-                current += shift;
+                current += shiftChar;
                 encoded.append((char) (current > 'z' ? current - 26 : current)); // 26 = number of latin letters
             } else {
                 encoded.append(current);
@@ -50,16 +53,16 @@ public class Caesar {
     public String decode(String encryptedMessage, int shift) {
         StringBuilder decoded = new StringBuilder();
 
-        shift %= 26;
+        final char shiftChar = normalizeShift(shift);
 
         final int length = encryptedMessage.length();
         for (int i = 0; i < length; i++) {
             char current = encryptedMessage.charAt(i);
             if (isCapitalLatinLetter(current)) {
-                current -= shift;
+                current -= shiftChar;
                 decoded.append((char) (current < 'A' ? current + 26 : current)); // 26 = number of latin letters
             } else if (isSmallLatinLetter(current)) {
-                current -= shift;
+                current -= shiftChar;
                 decoded.append((char) (current < 'a' ? current + 26 : current)); // 26 = number of latin letters
             } else {
                 decoded.append(current);
diff --git a/src/main/java/com/thealgorithms/maths/AliquotSum.java b/src/main/java/com/thealgorithms/maths/AliquotSum.java
index 0dbc58bed..996843b56 100644
--- a/src/main/java/com/thealgorithms/maths/AliquotSum.java
+++ b/src/main/java/com/thealgorithms/maths/AliquotSum.java
@@ -56,7 +56,7 @@ public final class AliquotSum {
         // if n is a perfect square then its root was added twice in above loop, so subtracting root
         // from sum
         if (root == (int) root) {
-            sum -= root;
+            sum -= (int) root;
         }
         return sum;
     }
diff --git a/src/main/java/com/thealgorithms/maths/PerfectNumber.java b/src/main/java/com/thealgorithms/maths/PerfectNumber.java
index 2a935b067..f299d08e5 100644
--- a/src/main/java/com/thealgorithms/maths/PerfectNumber.java
+++ b/src/main/java/com/thealgorithms/maths/PerfectNumber.java
@@ -63,7 +63,7 @@ public final class PerfectNumber {
         // if n is a perfect square then its root was added twice in above loop, so subtracting root
         // from sum
         if (root == (int) root) {
-            sum -= root;
+            sum -= (int) root;
         }
 
         return sum == n;